Pil0tXia commented on code in PR #4543:
URL: https://github.com/apache/eventmesh/pull/4543#discussion_r1384268993


##########
.github/workflows/ci.yml:
##########
@@ -48,6 +48,11 @@ jobs:
           # queries: ./path/to/local/query, your-org/your-repo/queries@main
           languages: ${{ matrix.language }}
 
+      - if: matrix.language == 'cpp' || matrix.language == 'csharp'
+        name: Build C
+        run: |
+          make   

Review Comment:
   In #4323, c sdk adds some third-party libraries using submodules. git 
doesn't clone or use submodules by default. Needs to make or scan them after 
adding them.
   
   ---
   
   在 #4323 中,c 
sdk使用了submodule的方式添加了一些第三方库。git默认是不clone或使用submodule的,需要添加它们之后再make或扫描。



##########
.github/workflows/ci.yml:
##########
@@ -48,6 +48,11 @@ jobs:
           # queries: ./path/to/local/query, your-org/your-repo/queries@main
           languages: ${{ matrix.language }}
 
+      - if: matrix.language == 'cpp' || matrix.language == 'csharp'
+        name: Build C
+        run: |
+          make   

Review Comment:
   In #4323, c sdk adds some third-party libraries using submodules. git 
doesn't clone or use submodules by default. Needs to make or scan them after 
adding them.
   
   ---
   
   在 #4323 中,c 
sdk使用了submodule的方式添加了一些第三方库。git默认是不clone或使用submodule的,需要添加它们之后再make或扫描。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to