pandaapo commented on code in PR #4543:
URL: https://github.com/apache/eventmesh/pull/4543#discussion_r1384451026
##########
.github/workflows/ci.yml:
##########
@@ -48,6 +48,11 @@ jobs:
# queries: ./path/to/local/query, your-org/your-repo/queries@main
languages: ${{ matrix.language }}
+ - if: matrix.language == 'cpp' || matrix.language == 'csharp'
+ name: Build C
+ run: |
+ make
Review Comment:
> The matrix does not define a `language` property, so `matrix.language`
evaluates to `null`.
It doesn't seem like that's the reason. When C code was not introduced in
this project, and the matrix did not define a `language` property, CodeQL can
work normally in both ubuntu and macOS. For example, the following is the
previous normal
[CodeQL](https://github.com/apache/eventmesh/actions/runs/6716258374/job/18252455667).
##########
.github/workflows/ci.yml:
##########
@@ -48,6 +48,11 @@ jobs:
# queries: ./path/to/local/query, your-org/your-repo/queries@main
languages: ${{ matrix.language }}
+ - if: matrix.language == 'cpp' || matrix.language == 'csharp'
+ name: Build C
+ run: |
+ make
Review Comment:
> The matrix does not define a `language` property, so `matrix.language`
evaluates to `null`.
It doesn't seem like that's the reason. When C code was not introduced in
this project, and the matrix did not define a `language` property, CodeQL can
work normally in both ubuntu and macOS. For example, the following is the
previous normal
[CodeQL](https://github.com/apache/eventmesh/actions/runs/6716258374/job/18252455667).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
