pandaapo commented on code in PR #4591:
URL: https://github.com/apache/eventmesh/pull/4591#discussion_r1411598889
##########
eventmesh-connectors/eventmesh-connector-dingtalk/src/main/java/org/apache/eventmesh/connector/dingtalk/config/DingDingMessageTemplateType.java:
##########
@@ -21,23 +21,30 @@
public enum DingDingMessageTemplateType {
- PLAIN_TEXT("sampleText"),
- MARKDOWN("sampleMarkdown");
+ PLAIN_TEXT("text", "sampleText"),
+ MARKDOWN("markdown", "sampleMarkdown");
Review Comment:
When users want to use sinks like DingTalk or WeCom that require specific
attribute values, is there a way for them to easily and clearly know which text
to choose as the configuration or which attribute values can be configured? Add
comments to this class and field? Or use an MD document for instructions on how
to use it?
The same issue applies to specific property names defined by
`ConnectRecordExtensionKeys`.
当用户想要使用像DingTalk或WeCom这类需要特定属性值的sink时，有没有办法让用户比较容易、比较明确地知道他们应该选择哪个文本作为配置，或者是很清楚地知道可以配置哪些属性值？在该类和字段上加注释？还是用md文档做使用说明？
对于`ConnectRecordExtensionKeys`定义的特定的属性名称，也是同样的问题。
##########
eventmesh-connectors/eventmesh-connector-dingtalk/src/main/java/org/apache/eventmesh/connector/dingtalk/config/DingDingMessageTemplateType.java:
##########
@@ -21,23 +21,30 @@
public enum DingDingMessageTemplateType {
- PLAIN_TEXT("sampleText"),
- MARKDOWN("sampleMarkdown");
+ PLAIN_TEXT("text", "sampleText"),
+ MARKDOWN("markdown", "sampleMarkdown");
Review Comment:
When users want to use sinks like DingTalk or WeCom that require specific
attribute values, is there a way for them to easily and clearly know which text
to choose as the configuration or which attribute values can be configured? Add
comments to this class and field? Or use an MD document for instructions on how
to use it?
The same issue applies to specific property names defined by
`ConnectRecordExtensionKeys`.
当用户想要使用像DingTalk或WeCom这类需要特定属性值的sink时，有没有办法让用户比较容易、比较明确地知道他们应该选择哪个文本作为配置，或者是很清楚地知道可以配置哪些属性值？在该类和字段上加注释？还是用md文档做使用说明？
对于`ConnectRecordExtensionKeys`定义的特定的属性名称，也是同样的问题。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
