hhuang1231 commented on code in PR #4591:
URL: https://github.com/apache/eventmesh/pull/4591#discussion_r1411692104
##########
eventmesh-connectors/eventmesh-connector-dingtalk/src/main/java/org/apache/eventmesh/connector/dingtalk/config/DingDingMessageTemplateType.java:
##########
@@ -21,23 +21,30 @@
public enum DingDingMessageTemplateType {
- PLAIN_TEXT("sampleText"),
- MARKDOWN("sampleMarkdown");
+ PLAIN_TEXT("text", "sampleText"),
+ MARKDOWN("markdown", "sampleMarkdown");
Review Comment:
I think it is necessary to write the usage method in the md document, so
that users can quickly understand how to use the connector.
我认为有必要将使用方式写在md文档中，以便用户能够快速了解如何使用。
##########
eventmesh-connectors/eventmesh-connector-dingtalk/src/main/java/org/apache/eventmesh/connector/dingtalk/config/DingDingMessageTemplateType.java:
##########
@@ -21,23 +21,30 @@
public enum DingDingMessageTemplateType {
- PLAIN_TEXT("sampleText"),
- MARKDOWN("sampleMarkdown");
+ PLAIN_TEXT("text", "sampleText"),
+ MARKDOWN("markdown", "sampleMarkdown");
Review Comment:
I think it is necessary to write the usage method in the md document, so
that users can quickly understand how to use the connector.
我认为有必要将使用方式写在md文档中，以便用户能够快速了解如何使用。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
