hhuang1231 commented on code in PR #4591:
URL: https://github.com/apache/eventmesh/pull/4591#discussion_r1411678072
##########
eventmesh-examples/src/main/resources/application.properties:
##########
@@ -24,4 +24,5 @@ eventmesh.selector.type=nacos
eventmesh.selector.nacos.address=127.0.0.1:8848
eventmesh.catalog.name=EVENTMESH-catalog
eventmesh.workflow.name=EVENTMESH-workflow
-eventmesh.connector.dingtalkTemplateType=sampleText
\ No newline at end of file
+eventmesh.connector.dingtalkTemplateType=text
+eventmesh.connector.wecomTemplateType=text
Review Comment:
Is it possible to explicitly inform the user whether the kv written by the
user is correct after parsing these extended fields in the configuration file?
是否可以在解析完配置文件中这些扩展字段后，显式的告知用户编写的kv是否正确？
##########
eventmesh-connectors/eventmesh-connector-dingtalk/src/main/java/org/apache/eventmesh/connector/dingtalk/config/DingDingMessageTemplateType.java:
##########
@@ -21,23 +21,30 @@
public enum DingDingMessageTemplateType {
- PLAIN_TEXT("sampleText"),
- MARKDOWN("sampleMarkdown");
+ PLAIN_TEXT("text", "sampleText"),
+ MARKDOWN("markdown", "sampleMarkdown");
Review Comment:
I think it is necessary to write the usage method in the md document, so
that users can quickly understand how to use the connector.
我认为将使用方式写在md文档中是有必要的，这能让用户更快的了解如何使用该connector。
##########
eventmesh-connectors/eventmesh-connector-dingtalk/src/main/java/org/apache/eventmesh/connector/dingtalk/config/DingDingMessageTemplateType.java:
##########
@@ -21,23 +21,30 @@
public enum DingDingMessageTemplateType {
- PLAIN_TEXT("sampleText"),
- MARKDOWN("sampleMarkdown");
+ PLAIN_TEXT("text", "sampleText"),
+ MARKDOWN("markdown", "sampleMarkdown");
Review Comment:
I think it is necessary to write the usage method in the md document, so
that users can quickly understand how to use the connector.
我认为将使用方式写在md文档中是有必要的，这能让用户更快的了解如何使用该connector。
##########
eventmesh-examples/src/main/resources/application.properties:
##########
@@ -24,4 +24,5 @@ eventmesh.selector.type=nacos
eventmesh.selector.nacos.address=127.0.0.1:8848
eventmesh.catalog.name=EVENTMESH-catalog
eventmesh.workflow.name=EVENTMESH-workflow
-eventmesh.connector.dingtalkTemplateType=sampleText
\ No newline at end of file
+eventmesh.connector.dingtalkTemplateType=text
+eventmesh.connector.wecomTemplateType=text
Review Comment:
Is it possible to explicitly inform the user whether the kv written by the
user is correct after parsing these extended fields in the configuration file?
是否可以在解析完配置文件中这些扩展字段后，显式的告知用户编写的kv是否正确？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
