xwm1992 commented on code in PR #4698:
URL: https://github.com/apache/eventmesh/pull/4698#discussion_r1441787627
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/file/WatchFileManager.java:
##########
@@ -62,10 +60,10 @@ private static void shutdown() {
return;
}
- LogUtils.info(log, "[WatchFileManager] start close");
+ log.atInfo().log("[WatchFileManager] start close");
Review Comment:
这里的性能会更好，应该还是部分特殊的情况（适用于能够懒加载的情况），既然LogUtils能解决日志代码行显示的问题，我觉得也可以采用LogUtils统一封装一下，这样在编码风格上也能有一定的统一。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
