Pil0tXia commented on code in PR #4698:
URL: https://github.com/apache/eventmesh/pull/4698#discussion_r1443639011
##########
build.gradle:
##########
@@ -40,15 +40,6 @@ buildscript {
}
}
-//Remove doclint warnings that pollute javadoc logs when building with java8
-if(JavaVersion.current().isJava8()){
Review Comment:
JDK11 failed to execute task `javadoc` (c.f.
https://github.com/apache/eventmesh/actions/runs/7406186071/job/20162982838),
because of the JavaDoc I wrote in
https://github.com/apache/eventmesh/pull/4698/commits/7c1c2ddb72a47fb30ffe4a98a4ac88e69a283088.
I had a re-check and it seems that I have to and another code tag to make
JDK11 javadoc build success:
During my troubleshooting process, I noticed that the `javadoc.options` file
does not provide any useful information, which led me to test the reason for
needing a closing `</p>` tag or indentation or other issues. It was quite
time-consuming.
[javadoc.options.txt](https://github.com/apache/eventmesh/files/13848546/javadoc.options.txt)
In your opinion, do you think it would be better to keep the javadoc task
settings as they are, only effective for JDK 8, or would it be better to remove
the "if" condition for JDK 8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
