pandaapo commented on code in PR #4698:
URL: https://github.com/apache/eventmesh/pull/4698#discussion_r1443612429
##########
build.gradle:
##########
@@ -40,15 +40,6 @@ buildscript {
}
}
-//Remove doclint warnings that pollute javadoc logs when building with java8
-if(JavaVersion.current().isJava8()){
Review Comment:
Does Java 11 still supports `doclint`?
##########
eventmesh-webhook/eventmesh-webhook-receive/src/main/java/org/apache/eventmesh/webhook/receive/WebHookController.java:
##########
@@ -123,12 +123,12 @@ public void execute(String path, Map<String, String>
header, byte[] body) throws
@Override
public void onSuccess(SendResult sendResult) {
- LogUtils.debug(log, sendResult.toString());
+ LogUtil.debug(log, "", sendResult::toString);
Review Comment:
These parameters are passed to
`builder.addArgument(sendResult::toString).log("")`, how will the return value
of `sendResult::toString` be output after processing?
这样的参数，经过`builder.addArgument(sendResult::toString).log("")`处理后，`sendResult::toString`的返回值会如何被输出？
##########
eventmesh-openconnect/eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java:
##########
@@ -330,15 +330,15 @@ public boolean commitOffsets() {
log.info("{} Committing offsets for {} acknowledged messages",
this, committableOffsets.numCommittableMessages());
if (committableOffsets.hasPending()) {
log.debug("{} There are currently {} pending messages spread
across {} source partitions whose offsets will not be committed. "
- + "The source partition with the most pending messages
is {}, with {} pending messages",
+ + "The source partition with the most pending messages is
{}, with {} pending messages",
Review Comment:
Bring a situation unrelated to the purpose of this PR to the attention of
the community: the automatic modification of this format seems to create a
burden of constant modification, such as this line starting with no
indentation, then adding indentation, and now removing indentation again.
一个和本PR目标无关的情况，提出来让社区注意一下：这种格式的自动修改，似乎带来一种改来改去的情况，比如这一行开始没有缩进，然后加上了缩进，现在移除了缩进。
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/AbstractTCPServer.java:
##########
@@ -81,6 +80,8 @@
@Slf4j
public class AbstractTCPServer extends AbstractRemotingServer {
+ private static final Logger MESSAGE_LOGGER =
LoggerFactory.getLogger(EventMeshConstants.MESSAGE);
Review Comment:
Can this field be kept in `TcpDispatcher`?
##########
eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/producer/EventMeshGrpcProducer.java:
##########
@@ -61,7 +61,7 @@ public EventMeshGrpcProducer(EventMeshGrpcClientConfig
clientConfig) {
}
public <T> Response publish(T message) {
- LogUtils.info(log, "Publish message ", message.toString());
+ LogUtil.info(log, "Publish message ", message::toString);
Review Comment:
There is no placeholder `{}`, After processed by ` builder. addArgument
(message::toString). log("xxx")`, how will the return value of
`message::toString` be output?
没有占位符`{}`，经过`builder.addArgument(sendResult::toString).log(xxx);`处理后，`message::toString`返回值会如何被输出？
##########
build.gradle:
##########
@@ -94,6 +85,10 @@ allprojects {
.exclude('**/org/apache/eventmesh/connector/openfunction/client/CallbackServiceGrpc**')
.exclude('**/org/apache/eventmesh/connector/jdbc/antlr**')
+ configurations {
+ errorprone.extendsFrom(annotationProcessor)
Review Comment:
For all integration code related to Error Prone, I suggest not adding code
that is currently not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
