[
https://issues.apache.org/jira/browse/FINERACT-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120979#comment-17120979
]
Michael Vorburger commented on FINERACT-822:
--------------------------------------------
[~Collins] why did your Resolve this issue? Please do not Resolve issues you
are not working on or yourself reviewing. [~Percy Ashu] first PR was only a
(small...) start for this - there's still (much!) more to be done... :P The
goal here, IMHO, should be to have ALL bug patterns from Error Prone which we
reasonably can enabled for Fineract, note the "//Todo Remove necessary checks
from this list" & "//TODO gradually enable these checks" in
fineract-provider/build.gradle... So far we're still running a (quite limited)
subset of them, only. I'm pretty sure there are more "interesting" bugs such as
FINERACT-1014 which this will help us find to squash!
> Enable and enforce (!) Google's Error Prone quality check tool in Fineract
> --------------------------------------------------------------------------
>
> Key: FINERACT-822
> URL: https://issues.apache.org/jira/browse/FINERACT-822
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger
> Assignee: Percy Ashu
> Priority: Major
> Fix For: 1.4.0
>
>
> As tracked in overall FINERACT-712, similarly to SpotBugs (FINERACT-702), PMD
> and Checkstyle (FINERACT-821), I would suggest that we also enable and
> enforce Error Prone quality check tool in Fineract to catch any obvious
> programming error bugs.
> Error Prone is extensively used inside Google private code base, has been
> open sourced, and is meanwhile popular in many open source projects as well
> (see other Apache projects' use). More information is available on
> [https://errorprone.info|https://errorprone.info/] and
> [https://github.com/google/error-prone].
> I have spent a fair amount of time in a past life on a project (which I'm
> currently no longer actively invoved in) to refine a what I believe to be
> "good" Error Prone rule set, we could reuse this for Fineract (it's EPL
> licensed, so copy/pasting it is perfectly fine), see
> https://github.com/opendaylight/infrautils/blob/master/common/parent/pom.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
