[
https://issues.apache.org/jira/browse/FINERACT-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140912#comment-17140912
]
Percy Ashu commented on FINERACT-822:
-------------------------------------
{color:#6a8759}"UnusedVariable"{color}, 473 //not a priority depends of if
variable is read.
{color:#6a8759}"SameNameButDifferent"{color}, 12
{color:#6a8759}"UnusedMethod"{color}, 11//not a priority
{color:#6a8759}"ModifiedButNotUsed"{color}, 4//
{color:#6a8759}"TypeParameterUnusedInFormals"{color}, 5//
{color:#6a8759}"UnusedNestedClass"{color}, 1//
{color:#6a8759}"UndefinedEquals"{color}, 19//
{color:#6a8759}"JdkObsolete"{color}, 124// Date to joda or java time
{color:#6a8759}"MissingSummary"{color}, 244//
{color:#6a8759}"MutablePublicArray"{color}, 6//
{color:#6a8759}"InvalidParam"{color}, 33//
{color:#6a8759}"ReturnFromVoid"{color}, 4//
{color:#6a8759}"AlmostJavadoc"{color}, 12//
{color:#6a8759}"PublicConstructorForAbstractClass"{color}, 6//
{color:#6a8759}"ProtectedMembersInFinalClass"{color}, 12//
{color:#6a8759}"StaticAssignmentInConstructor"{color}, 1//
{color:#6a8759}"UnescapedEntity"{color}, 3//
{color:#6a8759}"ModifyCollectionInEnhancedForLoop"{color}, 2//
{color:#6a8759}"NonCanonicalType"{color}, 2
{color:#6a8759}"InvalidInlineTag"{color}, 1{color:#6a8759}
"InconsistentOverloads", {color:#172b4d}150 //{color}
"MethodCanBeStatic", {color:#172b4d}301 //{color}
"Var", >{color:#172b4d}49000 // can be fixed with IDE if necessary.{color}
"ConstantField", {color:#172b4d}97//{color}
"FieldCanBeFinal", {color:#172b4d}too many//{color}
{color}
{color:#808080} {color}
> Enable and enforce (!) Google's Error Prone quality check tool in Fineract
> --------------------------------------------------------------------------
>
> Key: FINERACT-822
> URL: https://issues.apache.org/jira/browse/FINERACT-822
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger
> Assignee: Percy Ashu
> Priority: Major
> Fix For: 1.4.0
>
>
> As tracked in overall FINERACT-712, similarly to SpotBugs (FINERACT-702), PMD
> and Checkstyle (FINERACT-821), I would suggest that we also enable and
> enforce Error Prone quality check tool in Fineract to catch any obvious
> programming error bugs.
> Error Prone is extensively used inside Google private code base, has been
> open sourced, and is meanwhile popular in many open source projects as well
> (see other Apache projects' use). More information is available on
> [https://errorprone.info|https://errorprone.info/] and
> [https://github.com/google/error-prone].
> I have spent a fair amount of time in a past life on a project (which I'm
> currently no longer actively invoved in) to refine a what I believe to be
> "good" Error Prone rule set, we could reuse this for Fineract (it's EPL
> licensed, so copy/pasting it is perfectly fine), see
> https://github.com/opendaylight/infrautils/blob/master/common/parent/pom.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
