[
https://issues.apache.org/jira/browse/FINERACT-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141002#comment-17141002
]
Michael Vorburger commented on FINERACT-822:
--------------------------------------------
[~Percy Ashu] thanks a lot for putting this very nice and useful list together!
What I would suggest you do to finish up this issue by still taking care of
some that have under 20 violations (but without the purely JavaDoc related
ones), so, in suggested order: (BTW perhaps you want to start "grouping" some
of these together into single combined PRs, instead of having to raise separate
PRs; I don't mind that anymore so much, at this stage):
"UndefinedEquals", 19// *this one seems VERY important to me actually,
[https://errorprone.info/bugpattern/UndefinedEquals] looks like this can cause
real bugs*
"[UnusedMethod|https://errorprone.info/bugpattern/UnusedMethod]";, 11// No this
is bad, *just go ahead and boldly remove those un-used private methods!*
"[UnusedNestedClass|https://errorprone.info/bugpattern/UnusedNestedClass]";,
1// again, just remove this kind of un-used stuff
"SameNameButDifferent", 12
[https://errorprone.info/bugpattern/SameNameButDifferent]
"ModifiedButNotUsed", 4//
"PublicConstructorForAbstractClass", 6//
"ProtectedMembersInFinalClass", 12//
"UnescapedEntity", 3//
"ModifyCollectionInEnhancedForLoop", 2//
"NonCanonicalType", 2
"MutablePublicArray", 6//
"StaticAssignmentInConstructor", 1//
"TypeParameterUnusedInFormals", 5//
"InvalidInlineTag", 1
Now the following I'm totally OK with you just forgetting about and ignoring as
per [https://en.wikipedia.org/wiki/Diminishing_returns] :
"FieldCanBeFinal", too many//
"InconsistentOverloads", 150 //
"ConstantField", 97//
"MethodCanBeStatic", 301 //
"UnusedVariable", 473 //not a priority depends of if variable is read.
All of these seems to be purely related to JavaDoc (is that correct), and
perfect JavaDoc is a low priority for this project IMHO, just forget about it:
"MissingSummary", 244//
"AlmostJavadoc", 12//
"InvalidParam", 33//
"ReturnFromVoid", 4//
Then all that will be left is just:
"JdkObsolete", 124// Date to joda or java time *FINERACT-826 will take care of
that later (I think?)*
"Var", >49000 // can be fixed with IDE if necessary. *Yeah sure please ignore
this one, it's a lot of work (although I think it's actually "useful", but
never mind; fine)*
> Enable and enforce (!) Google's Error Prone quality check tool in Fineract
> --------------------------------------------------------------------------
>
> Key: FINERACT-822
> URL: https://issues.apache.org/jira/browse/FINERACT-822
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger
> Assignee: Percy Ashu
> Priority: Major
> Fix For: 1.4.0
>
>
> As tracked in overall FINERACT-712, similarly to SpotBugs (FINERACT-702), PMD
> and Checkstyle (FINERACT-821), I would suggest that we also enable and
> enforce Error Prone quality check tool in Fineract to catch any obvious
> programming error bugs.
> Error Prone is extensively used inside Google private code base, has been
> open sourced, and is meanwhile popular in many open source projects as well
> (see other Apache projects' use). More information is available on
> [https://errorprone.info|https://errorprone.info/] and
> [https://github.com/google/error-prone].
> I have spent a fair amount of time in a past life on a project (which I'm
> currently no longer actively invoved in) to refine a what I believe to be
> "good" Error Prone rule set, we could reuse this for Fineract (it's EPL
> licensed, so copy/pasting it is perfectly fine), see
> https://github.com/opendaylight/infrautils/blob/master/common/parent/pom.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
