[
https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212602#comment-17212602
]
Aleksandar Vidakovic commented on FINERACT-1188:
------------------------------------------------
[~vorburger]
Ok... I am currently trying this out from scratch with a brand new branch...
and there are a couple of issues here: Having the build folder artificially set
inside the project root (including twisting various plugins to point to that
build folder) just doesn't work with multi-module (no idea why this was set
like this anyway; the defaults usually work very well and I see no reason why a
fineract-provider/build in the original code wouldn't have worked)
So, the top-level is also a project (a simple one, but still); the "clean" task
creates a concurrency issue, because child projects (fineract-provider) run
their clean tasks in parallel. This is important, because plugins like the
Swagger file generator "think" they've already created all necessary files
(they did), but are unaware that the root project deleted the contents of the
build folder (and all generated artifacts).
I thought the solution for that is to just leave every module's build folder to
itself (i.e. "fineract-provider/build" etc.), but there are still things
failing... and I have a feeling it's because we have parts that are defined at
root level and also in the build.gradle; I'm not talking about duplication
(removed already), I get the impression that either this is done properly for
everything (that can be defined on the top level) or we can chase these
Heisenbugs for longer. Not sure how to proceed here best, but this micro-step
approach is a bit debug intensive.
If you want to give this a shot yourself then please go ahead; can't exclude
that I'm missing something (maybe simple) here, but for now I will leave this
aside and maybe have later a fresh start hopefully with another idea how to do
this step by step.
> README and other files are not covered by Spotless
> --------------------------------------------------
>
> Key: FINERACT-1188
> URL: https://issues.apache.org/jira/browse/FINERACT-1188
> Project: Apache Fineract
> Issue Type: Sub-task
> Reporter: Michael Vorburger
> Assignee: Aleksandar Vidakovic
> Priority: Major
>
> Would it be possible to extract JUST the work related to make README and
> other files are covered by Spotless from
> [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171]
> and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and
> keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client,
> fineract-doc - is that possible?
> You could perhaps before that even make a PR #0 with JUST the trivial
> formatting changes itself which Spotbugs made once you change the layout, but
> without any build change - just send them first, separately - get that out of
> the way?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
