[
https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212752#comment-17212752
]
Aleksandar Vidakovic commented on FINERACT-1188:
------------------------------------------------
[~ptuomola] [~vorburger]
Well, can't live in a world where I'm losing against a Gradle task ;) ... as I
said above there was an issue with the clean task, but the source of this is
not exactly what I described. I thought that the root project and
fineract-provider are somehow competing against each other. Turns out: the
shell script execution of the Gradle setup inside the build folder that was
created by the Swagger code generator is messing things up. I tried all kinds
of tricks to twist the clean task's arm, but I was doing it in the wrong place!
Turning off the code generator and not executing the generated Gradle file...
makes everything work. I got a hint about this issue when Spotless suddenly
showed rule violations in that generated code; just needed to exclude all
"build" folders; strange thing is why it worked before, because I think it
shouldn't have... single module or not doesn't really matter... the build
folder was not excluded before so Spotless should have complained, but it
didn't.
Another potential issue: having two buildscript sections doesn't seem to be a
good idea, so I moved it to the root build.gradle file. I think that was also
the reason why source folders would show up in Eclipse both in the root project
("fineract") and the child module ("fineract-provider"). Will test this again.
Anyway... looks like there's progress... only 3 files changed so far... should
be a lot easier to review too.
FYI
> README and other files are not covered by Spotless
> --------------------------------------------------
>
> Key: FINERACT-1188
> URL: https://issues.apache.org/jira/browse/FINERACT-1188
> Project: Apache Fineract
> Issue Type: Sub-task
> Reporter: Michael Vorburger
> Assignee: Aleksandar Vidakovic
> Priority: Major
>
> Would it be possible to extract JUST the work related to make README and
> other files are covered by Spotless fromÂ
> [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171]
> and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and
> keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client,
> fineract-doc - is that possible?
> You could perhaps before that even make a PR #0 with JUST the trivial
> formatting changes itself which Spotbugs made once you change the layout, but
> without any build change - just send them first, separately - get that out of
> the way?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
