[
https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212801#comment-17212801
]
Aleksandar Vidakovic commented on FINERACT-1188:
------------------------------------------------
Alright, this looks much better. Full build with all artifacts is working,
Eclipse project import works including immediate Gradle build execution and
source directories are shown in Eclipse only under fineract-provider (as
expected, because it's the only Java module); in my previous attempt source
folders appeared both in the root project "fineract" and "fineract-provider"
which was wrong.
The Docker build is also working which I think was the in my previous attempt
to run the final health tests successfully in Travis.
Would be great if you guys could have a look at this, the diff is a lot easier
to review this time. Thanks again.
> README and other files are not covered by Spotless
> --------------------------------------------------
>
> Key: FINERACT-1188
> URL: https://issues.apache.org/jira/browse/FINERACT-1188
> Project: Apache Fineract
> Issue Type: Sub-task
> Reporter: Michael Vorburger
> Assignee: Aleksandar Vidakovic
> Priority: Major
>
> Would it be possible to extract JUST the work related to make README and
> other files are covered by Spotless from
> [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171]
> and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and
> keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client,
> fineract-doc - is that possible?
> You could perhaps before that even make a PR #0 with JUST the trivial
> formatting changes itself which Spotbugs made once you change the layout, but
> without any build change - just send them first, separately - get that out of
> the way?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
