vidakovic commented on code in PR #5613:
URL: https://github.com/apache/fineract/pull/5613#discussion_r2927390841
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/FixedDepositProduct.java:
##########
@@ -241,8 +242,70 @@ private boolean removeChart(InterestRateChart chart) {
return charts.remove(chart);
}
- public void setHelpers(final InterestRateChartAssembler chartAssembler) {
- this.chartAssembler = chartAssembler;
+ private InterestRateChart assembleNewChart(JsonObject chartElement, String
currencyCode, DataValidatorBuilder baseDataValidator) {
Review Comment:
My first question: does anything named "interest rate" belong in a package
with the name "savings"? And even if did: why JsonObject? That seems
unnecessary now that interest rate charts are type safe....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
