vidakovic commented on code in PR #5613:
URL: https://github.com/apache/fineract/pull/5613#discussion_r2930364711
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/FixedDepositProduct.java:
##########
@@ -241,8 +242,70 @@ private boolean removeChart(InterestRateChart chart) {
return charts.remove(chart);
}
- public void setHelpers(final InterestRateChartAssembler chartAssembler) {
- this.chartAssembler = chartAssembler;
+ private InterestRateChart assembleNewChart(JsonObject chartElement, String
currencyCode, DataValidatorBuilder baseDataValidator) {
Review Comment:
Why is this here? We are doing here something that is related to the REST
API/communication protocol, but the package is related to the storage layer...
not ideal and kind of violates the architecture layers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
