vidakovic commented on code in PR #5613:
URL: https://github.com/apache/fineract/pull/5613#discussion_r2927397885


##########
fineract-validation/src/main/resources/ValidationMessages.properties:
##########
@@ -79,3 +79,65 @@ 
org.apache.fineract.portfolio.paymenttype.description.size=The parameter 'descri
 org.apache.fineract.portfolio.paymenttype.position.positive-or-zero=The 
parameter 'position' must be zero or positive
 org.apache.fineract.portfolio.paymenttype.code-name.size=The parameter 
'codeName' cannot exceed 100 characters
 org.apache.fineract.portfolio.is-system-defined.not-null=The parameter 
'isSystemDefined' is mandatory
+
+# Interest Rate Chart
+org.apache.fineract.portfolio.interestratechart.id.not-null=The parameter 'id' 
is mandatory
+org.apache.fineract.portfolio.interestratechart.name.not-blank=The parameter 
'name' cannot be blank
+org.apache.fineract.portfolio.interestratechart.description.size=The parameter 
'description' cannot exceed 1000 characters
+org.apache.fineract.portfolio.interestratechart.fromDate.not-null=The 
parameter 'fromDate' is mandatory
+org.apache.fineract.portfolio.interestratechart.toDate.not-null=The parameter 
'toDate' is mandatory
+
+# Interest Rate Chart Slabs
+org.apache.fineract.portfolio.interestratechartslabs.chart-id.not-null=The 
parameter 'chartId' is mandatory
+org.apache.fineract.portfolio.interestratechartslabs.chart-slab-id.not-null=The
 parameter 'chartSlabId' is mandatory
+org.apache.fineract.portfolio.interestratechartslabs.period-type.not-null=The 
parameter 'periodType' is mandatory
+org.apache.fineract.portfolio.interestratechartslabs.from-period.not-null=The 
parameter 'fromPeriod' is mandatory
+org.apache.fineract.portfolio.interestratechartslabs.to-period.not-null=The 
parameter 'toPeriod' is mandatory
+org.apache.fineract.portfolio.interestratechartslabs.annual-interest-rate.not-null=The
 parameter 'annualInterestRate' is mandatory
+org.apache.fineract.portfolio.interestratechartslabs.annual-interest-rate.decimal-min=The
 parameter 'annualInterestRate' must be greater than or equal to 0.0
+org.apache.fineract.portfolio.interestratechartslabs.description.size=The 
parameter 'description' cannot exceed 500 characters
+
+# Interest Rate Chart Slab Incentives
+org.apache.fineract.portfolio.interestratechartslabs.incentive.entity-type.not-null=The
 parameter 'entityType' is mandatory
+org.apache.fineract.portfolio.interestratechartslabs.incentive.attribute-name.not-null=The
 parameter 'attributeName' is mandatory
+org.apache.fineract.portfolio.interestratechartslabs.incentive.condition-type.not-null=The
 parameter 'conditionType' is mandatory
+org.apache.fineract.portfolio.interestratechartslabs.incentive.attribute-value.not-null=The
 parameter 'attributeValue' is mandatory
+org.apache.fineract.portfolio.interestratechartslabs.incentive.incentive-type.not-null=The
 parameter 'incentiveType' is mandatory
+org.apache.fineract.portfolio.interestratechartslabs.incentive.amount.not-null=The
 parameter 'amount' is mandatory
+
+# Fixed Deposit Product

Review Comment:
   Everything that does NOT belong in the interest rate domain has to go. Too 
large of a change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to