vidakovic commented on code in PR #5657:
URL: https://github.com/apache/fineract/pull/5657#discussion_r2972050010
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/address/service/ClientAddressWriteService.java:
##########
@@ -18,15 +18,18 @@
*/
package org.apache.fineract.portfolio.address.service;
-import org.apache.fineract.infrastructure.core.api.JsonCommand;
-import org.apache.fineract.infrastructure.core.data.CommandProcessingResult;
+import java.util.List;
+import org.apache.fineract.portfolio.address.data.ClientAddressCreateResponse;
+import org.apache.fineract.portfolio.address.data.ClientAddressUpdateResponse;
+import org.apache.fineract.portfolio.client.data.ClientAddressCreateRequest;
+import org.apache.fineract.portfolio.client.data.ClientAddressUpdateRequest;
import org.apache.fineract.portfolio.client.domain.Client;
-public interface AddressWritePlatformService {
+public interface ClientAddressWriteService {
- CommandProcessingResult addClientAddress(Long clientId, Long
addressTypeId, JsonCommand command);
+ ClientAddressCreateResponse createClientAddress(ClientAddressCreateRequest
request);
Review Comment:
What is the difference between `createClientAddress` and
`addNewClientAddress`? Only difference I see is in one you pass an client ID,
in the other the whole client object? On the surface looks like this is doing
the samem? can we eliminate one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
