vidakovic commented on code in PR #5657:
URL: https://github.com/apache/fineract/pull/5657#discussion_r2972070749
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -317,7 +318,12 @@ public CommandProcessingResult createClient(final
JsonCommand command) {
}
if (isAddressEnabled) {
-
this.addressWritePlatformService.addNewClientAddress(newClient, command);
+ final com.google.gson.JsonArray addressArray =
command.arrayOfParameterNamed("address");
Review Comment:
This is not type safety! This kind of thing is now consistently slipping
through the cracks. ANYTHING:
- GSON
- xxxParamterNamed
- JsonArray
- JsonXXX
- JsonCommand
- CommandWrapper
- CommandBuilder
... needs to go, because this is the goal of this exercise, to make things
type safe... all of the above is not. Again, maybe go a bit slower... otherwise
this feels a bit like a prompt loop. I don't mind reviewing... but let's keep
an eye on these details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
