vidakovic commented on code in PR #5657:
URL: https://github.com/apache/fineract/pull/5657#discussion_r2972057951
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientAddressApiResource.java:
##########
@@ -36,62 +35,53 @@
import jakarta.ws.rs.core.MediaType;
import java.util.List;
import lombok.RequiredArgsConstructor;
-import org.apache.fineract.commands.domain.CommandWrapper;
-import org.apache.fineract.commands.service.CommandWrapperBuilder;
-import
org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformService;
-import org.apache.fineract.infrastructure.core.data.CommandProcessingResult;
-import
org.apache.fineract.infrastructure.core.serialization.DefaultToApiJsonSerializer;
-import
org.apache.fineract.infrastructure.security.service.PlatformSecurityContext;
+import org.apache.fineract.command.core.CommandPipeline;
+import
org.apache.fineract.portfolio.address.command.ClientAddressCreateCommand;
+import
org.apache.fineract.portfolio.address.command.ClientAddressUpdateCommand;
import org.apache.fineract.portfolio.address.data.AddressData;
+import org.apache.fineract.portfolio.address.data.ClientAddressCreateResponse;
+import org.apache.fineract.portfolio.address.data.ClientAddressUpdateResponse;
import org.apache.fineract.portfolio.address.filter.ClientAddressSearchParam;
-import
org.apache.fineract.portfolio.address.service.AddressReadPlatformServiceImpl;
-import org.apache.fineract.portfolio.client.data.ClientAddressRequest;
+import org.apache.fineract.portfolio.address.service.ClientAddressReadService;
+import org.apache.fineract.portfolio.client.data.ClientAddressCreateRequest;
+import org.apache.fineract.portfolio.client.data.ClientAddressUpdateRequest;
import org.springframework.stereotype.Component;
@Path("/v1/client")
@Component
@Tag(name = "Clients Address", description = "Address module is an optional
module and can be configured into the system by using GlobalConfiguration
setting: enable-address. In order to activate Address module, we need to enable
the configuration, enable-address by setting its value to true.")
Review Comment:
Description is maybe better in triple quotes aka multi-line strings. This
here won't pass the Linter (aka Spotless plugin), whereas a multi-line string
allows you to make this readable for everyone and the linter won't touch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
