nidhiii128 opened a new pull request, #6085: URL: https://github.com/apache/fineract/pull/6085
JIRA: https://issues.apache.org/jira/browse/FINERACT-2293 Migrates the update client address endpoint (PUT /v1/client/{clientId}/addresses) from the legacy JsonCommand path to the new typed fineract-command framework. Scope (PR 2 of 2 for FINERACT-2293) - AddressMapper extended with @MappingTarget partial-update method (@BeanMapping(nullValuePropertyMappingStrategy = IGNORE) for clean null-skip) - AddressDomainService.update(AddressUpdateRequest) typed method - New AddressUpdateRequest / AddressUpdateResponse POJOs with Jakarta Validation - New AddressUpdateCommand and AddressUpdateCommandHandler - Controller routes PUT through CommandDispatcher, returns AddressUpdateResponse - AntMatcher added in SecurityConfig: PUT /api/*/client/*/addresses (UPDATE_ADDRESS) - Resilience4j retry config for commandAddressUpdate - Validation message bundle entries added - Legacy updateClientAddress(Long, JsonCommand) removed from AddressWritePlatformService - Legacy CommandWrapperBuilder.updateClientAddress(Long) removed - Legacy UpdateClientAddressCommandHandler deleted Depends on #6049 (PR 1 - create client address). This PR is currently based on that branch. Once #6049 merge in develop, I will rebase this on develop and force-push; that should reduce the diff to only the update-specific changes. Pattern follows the merged template-module reference (#5851) and PR 1 (#6049). Expected CI failure: run-api-backward-compatibility ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
