adamsaghy commented on code in PR #6174:
URL: https://github.com/apache/fineract/pull/6174#discussion_r3851652945
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularInterestPoster.java:
##########
@@ -150,6 +150,17 @@ private void batchUpdateJournalEntries(final
List<SavingsAccountData> savingsAcc
savingsAccountData.getId(),
auditDatetime, auditDatetime, false, BigDecimal.ZERO, BigDecimal.ZERO,
null,
savingsAccountTransactionData.getTransactionDate(), null, userId, userId,
DateUtils.getBusinessLocalDate() });
+ } else {
Review Comment:
I dont really like this idea:
- if no accounting is set on the loan product -> we should not reach this
point: Saving accounts without accounting should not be picked up
- If cash based accounting is set and no accrual transactions to be
created-> we should not reach this point: Savings accounts with Cash based
accounting (hence no Accruals) should not be picked up.
@bharathc27 What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
