Abhishek6122008 commented on code in PR #6174:
URL: https://github.com/apache/fineract/pull/6174#discussion_r3855711231
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularInterestPoster.java:
##########
@@ -150,6 +150,17 @@ private void batchUpdateJournalEntries(final
List<SavingsAccountData> savingsAcc
savingsAccountData.getId(),
auditDatetime, auditDatetime, false, BigDecimal.ZERO, BigDecimal.ZERO,
null,
savingsAccountTransactionData.getTransactionDate(), null, userId, userId,
DateUtils.getBusinessLocalDate() });
+ } else {
Review Comment:
@adamsaghy @bharathcgowda Thank you for the suggestions. Based on your
feedback, I was thinking of keeping this guard as a safety net, so that if the
account selection is tightened later, the branch would simply stop firing.
For the reporting gap Bharath mentioned, I was also thinking of collecting
the skipped/failed accounts and logging a single WARN summary per run instead
of the current silent debug.
Please let me know if you think this approach makes sense, and I'll go ahead
with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
