bharathcgowda commented on code in PR #6174:
URL: https://github.com/apache/fineract/pull/6174#discussion_r3853248764
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularInterestPoster.java:
##########
@@ -150,6 +150,17 @@ private void batchUpdateJournalEntries(final
List<SavingsAccountData> savingsAcc
savingsAccountData.getId(),
auditDatetime, auditDatetime, false, BigDecimal.ZERO, BigDecimal.ZERO,
null,
savingsAccountTransactionData.getTransactionDate(), null, userId, userId,
DateUtils.getBusinessLocalDate() });
+ } else {
Review Comment:
@adamsaghy I agree that non-accounting loan products and their associated
loans can be skipped. However, I believe income posting would still apply to
loan accounts under both cash-based and accrual-based accounting.
From a practical perspective, it makes sense for the job to continue
processing even if one account fails. However, we should maintain a list of the
accounts that failed, along with the relevant error messages, so that users can
review them and take the necessary action.
I hope this fix is taking care of that as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
