rk-roshan-kr opened a new pull request, #724: URL: https://github.com/apache/fineract-backoffice-ui/pull/724
## Description Issue #585 identified that multiple administrative and transactional form components lacked visual required-field indicators (*), on-blur touched validation feedback, and hints explaining why the submit button remained disabled. While PR #629 addressed this pattern for account-transfer-form, the remaining administrative forms continued to disable the submit button without field-level error messages or required markers. This PR implements the established required-marker and validation-feedback pattern across all 7 audited forms: 1. OfficeFormComponent (src/app/features/organization/offices/office-form.component.ts) 2. StaffFormComponent (src/app/features/organization/staff/staff-form.component.ts) 3. CodeFormComponent (src/app/features/system/codes/code-form.component.ts) 4. SavingsAccountTransactionFormComponent (src/app/features/products/savings-account-transaction-form.component.ts) 5. JournalEntryFormComponent (src/app/features/accounting/journal-entry-form.component.ts) 6. UserFormComponent (src/app/features/security/users/user-form.component.ts) 7. ClientFormComponent (src/app/features/clients/client-form.component.ts) ## Changes Made - Added visual required markers (*) to all mandatory field labels with danger styling. - Bound blur handlers to mark controls as touched when blurred. - Added accessible error notes (ion-note with role alert) referencing COMMON.REQUIRED and aria attributes. - Added polite submit hints informing users to complete required fields while forms are invalid. - Added and updated comprehensive unit test suites for all 7 components (68/68 passing tests). ## Verification - npm test: 7 test files, 68 tests passing - npm run lint: clean, 0 errors - npm run i18n:check: clean, 0 missing keys Fixes #585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
