parvarh26 commented on PR #724:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/724#issuecomment-6053685228
Hi @rk-roshan-kr,
Great work on this PR! Adding explicit required markers and surfacing real
validation feedback across all these admin forms makes the UX significantly
cleaner and saves users from guessing why buttons remain disabled.
A couple of minor observations while reviewing:
1. **Preserving architectural context in
`savings-account-transaction-form.component.ts`**:
In `savings-account-transaction-form.component.ts`, the existing
explanatory comment detailing why `paymentTypeId` is required by the backend to
prevent `POST 400` errors appears to have been removed during the template
refactoring. Since that comment provides great context for future contributors,
it might be worth keeping it intact.
2. **Public export boundary in `code-form.component.ts`**:
In `code-form.component.ts`, `CodesService` is re-exported on the
component's public interface rather than imported directly by the test spec
from `../../../api` (which is the convention followed in the other specs).
Keeping it consistent with the other spec imports would keep the component API
surface minimal.
3. **Adapter pipe alignment (`appTranslate`)**:
Now that PR #723 has landed on `main`, new template bindings benefit from
using `| appTranslate` from the adapter boundary (`src/app/core/adapters/`) to
remain consistent with ADR 0003.
Really solid contribution and great thoroughness across all the form files!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
