rk-roshan-kr commented on PR #724:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/724#issuecomment-6054084383
Hi @parvarh26,
Thanks for the thoughtful review and feedback! I've updated the branch to
address all the observations:
1. **Preserved architectural context in
`savings-account-transaction-form.component.ts`**:
- Restored the explanatory comment above `paymentTypeId` detailing why it
is required by the backend to prevent `400 Bad Request` errors.
2. **Public export boundary in `code-form.component.ts`**:
- Removed `export { CodesService }` from `code-form.component.ts`.
- Updated `code-form.component.test.ts` to import `CodesService` directly
from `../../../api` in line with the other spec files.
3. **Adapter pipe alignment (`appTranslate`)**:
- Rebased on latest `main` (incorporating PR #723) and aligned all
template translation bindings across all modified forms to `| appTranslate`.
4. **Resolved E2E Test timeouts**:
- **Root cause**: In `e2e/client-transfer.spec.ts` and
`full-demo.spec.ts`, `selectOption` calls for `Parent Office` and `Office`
timed out. The helper `ionSelect()` relied on exact text matching
(`getByText(label, { exact: true })`), which failed because adding `<span
class="required-marker">*</span>` inside `<ion-label>` made the element's text
`"Parent Office*"`.
- **Resolution**:
- Wrapped the label texts inside an inner `<span>` across the form
templates so exact text selectors isolate the label string cleanly from the
marker.
- Updated `ionSelect()` in `e2e/utils/ionic-locators.ts` to match
labels with optional trailing asterisks (`new RegExp(`^${label}\\*?$`)`).
All files have been formatted with Prettier and cryptographically signed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
