ayushcodes27 commented on PR #204: URL: https://github.com/apache/fineract-consumer-facing/pull/204#issuecomment-6155267133
Hi maintainers, a note on the failing CI before this goes further. LayeringArchitectureTest.featuresDoNotCallFineractFeignClientsDirectly fails on this PR. TransfersCommandServiceImpl is one of the services frozen in the ArchUnit baseline for that rule, and the baseline records its exact constructor signature. Adding the LoansQueryService dependency (needed to check the loan’s totalOutstanding and status) changes that signature, so the store treats it as a new violation. No new Feign client dependencies were added. I don’t want to work around this (for example by hand-editing the baseline or using setter injection) without your input. Two options: Preparatory refactor: move the three Feign calls (AccountTransfersApi, ClientApi, SavingsAccountApi) out of TransfersCommandServiceImpl into an infrastructure gateway, as a separate behavior-preserving PR. The baseline then shrinks, and this PR is rebased on top. Explicit baseline update: update the constructor lines for this class in the baseline in this PR, with your approval, since the violation count stays the same. Which would you prefer? Is anyone already migrating the frozen services? I’ll keep this PR in draft until we agree on the approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
