ayushcodes27 commented on code in PR #204:
URL:
https://github.com/apache/fineract-consumer-facing/pull/204#discussion_r4294625194
##########
consumer/src/main/java/org/apache/fineract/consumer/transfers/command/service/TransfersCommandServiceImpl.java:
##########
@@ -198,6 +203,7 @@ private void requireDestinationAllowed(Jwt jwt, Long
userId, Long toAccountId, b
if (!accessPolicyEvaluator.ownsResource(jwt, ResourceType.LOANS,
toAccountId)) {
throw new TransferAccessDeniedException();
}
+ requireWithinOutstanding(jwt, toAccountId, amount);
Review Comment:
Resolved: Fully documented both the best-effort/non-locking concurrency
limitation and the confirm-time idempotent retry behavior in transfers.adoc
under Design rationale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
