adamsaghy commented on code in PR #6546:
URL: https://github.com/apache/fineract/pull/6546#discussion_r4386911568
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/service/LoanScheduleAssembler.java:
##########
@@ -690,6 +719,16 @@ private void
validateRepaymentsStartDateWithMeetingDates(final LocalDate repayme
}
}
+ private void validateRepaymentsStartDateIsSemiMonthlyDueDate(final
LocalDate repaymentsStartingFromDate,
+ final SemiMonthlyDueDays semiMonthlyDueDays) {
+ if (!SemiMonthlyScheduleDates.isDueDate(repaymentsStartingFromDate,
semiMonthlyDueDays)) {
+ final String errorMessage = "First repayment date '" +
repaymentsStartingFromDate
+ + "' does not fall on a due day of the semi-monthly
schedule";
+ throw new
LoanApplicationDateException("first.repayment.date.not.a.semi.monthly.due.day",
errorMessage,
Review Comment:
Nit: the PR description says validation errors return 400, but
`LoanApplicationDateException` is a domain-rule exception, so this one is 403
(the IT asserts 403). Please update the description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
