adamsaghy commented on code in PR #6546:
URL: https://github.com/apache/fineract/pull/6546#discussion_r4394002274


##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java:
##########
@@ -124,6 +124,11 @@ public LocalDate generateNextRepaymentDate(final LocalDate 
lastRepaymentDate, fi
             LocalDate seedDate = null;
             String reccuringString = null;
             Calendar currentCalendar = loanApplicationTerms.getLoanCalendar();
+            if 
(loanApplicationTerms.getRepaymentPeriodFrequencyType().isSemiMonthly()) {
+                // The two due days are fixed points of the calendar month, so 
the next date is the first of them
+                // after the previous one rather than an offset added to it.
+                return SemiMonthlyScheduleDates.next(lastRepaymentDate, 
loanApplicationTerms.semiMonthlyDueDays());

Review Comment:
   @bharathcgowda @alberto-art3ch Please validate my findings



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to