alberto-art3ch commented on PR #6546: URL: https://github.com/apache/fineract/pull/6546#issuecomment-6457980022
> I ran two lifecycle cases on a local build of this head (progressive loans, interest recalculation on). Numbers below are from those runs. Confirmed, thanks for running it. With interest "same as repayment period" the rate factor only looks at the loan's own `repaymentPeriodFrequencyType` (`ProgressiveEMICalculator#calculateRateFactorPerPeriod`), never at the length of the period, and the re-aged periods are attached with the loan's configuration, so each monthly re-aged period gets 1/24. Your control numbers match the same code path at 1/12. Charging a re-aged period by its own frequency needs a frequency per period in the model, and the same mechanism today prices a monthly loan re-aged into weeks at 1/12 per week (the `isMonthly()` / `isWeekly()` branches are pre-existing), so that is an engine change of its own: follow-up FINERACT-XXXX. For this PR I took your second option. `LoanReAgingValidator` now rejects the re-age, and its preview, on a semi-monthly loan whose interest is calculated "same as repayment period" (403, `error.msg.loan.reage.not.allowed.on.semi.monthly.loan.with.interest.per.repayment.period`). Daily interest with actual days in month charges each re-aged period on its own days and stays allowed. Chapter updated: error table and Limitations now state that a semi-monthly loan is re-aged only with daily interest, and why. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
