Abhishek6122008 commented on code in PR #6817:
URL: https://github.com/apache/fineract/pull/6817#discussion_r4474149421


##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForSavings.java:
##########
@@ -58,6 +60,13 @@ public void createJournalEntriesForSavings(final SavingsDTO 
savingsDTO) {
 
             this.helper.checkForBranchClosures(latestGLClosure, 
transactionDate);
 
+            // a reversal undoes what was booked for the transaction, so it 
mirrors the stored entries instead of
+            // rebuilding them from the rules below, which may not be the ones 
the transaction was booked with
+            if (isReversal) {

Review Comment:
   Same as the cash processor: intended, covered by the same new ITs, args now 
pass false.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to