Abhishek6122008 commented on code in PR #6817:
URL: https://github.com/apache/fineract/pull/6817#discussion_r4474147502
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/CashBasedAccountingProcessorForSavings.java:
##########
@@ -57,6 +59,13 @@ public void createJournalEntriesForSavings(final SavingsDTO
savingsDTO) {
this.helper.checkForBranchClosures(latestGLClosure,
transactionDate);
+ // a reversal undoes what was booked for the transaction, so it
mirrors the stored entries instead of
+ // rebuilding them from the rules below, which may not be the ones
the transaction was booked with
+ if (isReversal) {
Review Comment:
Yes, intended: a reversal undoes what was booked, whatever the type, as for
loans. Besides SavingsChargeTaxIntegrationTest (undo of a taxed charge
payment), I added ITs that undo a deposit, a withdrawal and a withdrawal into
overdraft on cash and accrual products and check every GL account nets to zero.
The isReversal args below now pass false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
