Abhishek6122008 commented on code in PR #6817:
URL: https://github.com/apache/fineract/pull/6817#discussion_r4474152144
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccountingProcessorHelperImpl.java:
##########
@@ -494,6 +494,27 @@ public void
createCashBasedJournalEntriesAndReversalsForSavings(final Office off
loanId, transactionId, transactionDate, amount);
}
+ /**
+ * Books the opposite of every entry stored for a reversed savings
transaction, so the reversal nets to zero on each
+ * GL account however the transaction was booked: by an accounting
processor, or by the Post Interest For Savings
+ * job, which writes its own entries, and under GL mappings that may have
changed since. A transaction with nothing
+ * booked gets no reversal entries.
+ */
+ @Override
+ public void createJournalEntriesForReversedSavingsTransaction(final String
transactionId, final LocalDate transactionDate) {
Review Comment:
1. Yes, intended. Nothing booked means nothing to undo; the old one-sided
reversal left the GL off.
2. Yes, known. The mirror copies the entity type so it cancels the original.
I'll file the job's entity type separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
