sanvinaik opened a new pull request, #6810: URL: https://github.com/apache/fineract/pull/6810
## Description This PR fixes three read-permission checks that reference resource names which do not match the corresponding registered permission resource names. The incorrect resource identifiers can cause permission validation to be performed against non-existent resources. This change aligns each check with the canonical resource name used by Fineract. Changes: 1. Bulk Import – Funds - Updated TemplatePopulateImportConstants.FUNDS_ENTITY_TYPE from FUNDS to FUND. - Ensures that bulk import read-permission validation uses the correct funds resource identifier. 2. SMS Campaign – Preview - Replaced the incorrect SMS_CAMPAIGN resource identifier in the preview endpoint's read-permission check with SmsCampaignConstants.RESOURCE_NAME. - Reuses the existing canonical constant, which resolves to SMSCAMPAIGN, avoiding duplication and keeping the check consistent with the SMS campaign resource definition. 3. Two-Factor Configuration – Retrieve All - Corrected the resource identifier from TWOFACTOR_CONFIG to TWOFACTOR_CONFIGURATION. - Ensures that the retrieveAll endpoint validates read permissions against the registered two-factor configuration resource. ## Tests Added or updated regression tests to verify that the correct resource names are passed to the read permission checks. - BulkImportWorkbookPopulatorServiceImplTest - SmsCampaignApiResourceTest - TwoFactorConfigurationApiResourceTest All three targeted test classes pass. Apache RAT checks passed for fineract-provider and fineract-security. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
