Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/629#discussion_r29320567
  
    --- Diff: 
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/math/SparseVectorSuite.scala
 ---
    @@ -87,4 +87,33 @@ class SparseVectorSuite extends FlatSpec with Matchers {
     
         sparseVector should not equal(copy)
       }
    +
    +  it should "calculate dot product with SparseVector" in {
    +    val vec1 = SparseVector.fromCOO(4, (0, 1), (1, 0), (2, 1), (3, 0))
    +    val vec2 = SparseVector.fromCOO(4, (0, 0), (1, 1), (2, 0), (3, 1))
    --- End diff --
    
    Again non-zero entries are continuous starting from index 0. We should add 
a test case which works on more irregular non-zero entries.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to