[ 
https://issues.apache.org/jira/browse/FLINK-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991552#comment-15991552
 ] 

ASF GitHub Bot commented on FLINK-6334:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3791#discussion_r114063517
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
 ---
    @@ -56,6 +57,8 @@ case class Project(projectList: Seq[NamedExpression], 
child: LogicalNode) extend
                 case gcf: GetCompositeField => Alias(gcf, 
gcf.aliasName().getOrElse(s"_c$i"))
                 case other => Alias(other, s"_c$i")
               }
    +          // This happens when TableFunction.apply returns a Table, ex: 
t1.join(split('a) as 'b)
    +          case alias: Alias => alias
    --- End diff --
    
    Can we merge `Alias` before into the `LogicalTableFunctionCall` (maybe in 
`table.join()`?
    We should add as few special cases in the validation as possible, IMO.


> Refactoring UDTF interface
> --------------------------
>
>                 Key: FLINK-6334
>                 URL: https://issues.apache.org/jira/browse/FLINK-6334
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>
> The current UDTF leverages the table.join(expression) interface, which is not 
> a proper interface in terms of semantics. We would like to refactor this to 
> let UDTF use table.join(table) interface. Very briefly,  UDTF's apply method 
> will return a Table Type, so Join(UDTF('a, 'b, ...) as 'c) shall be viewed as 
> join(Table)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to