[ 
https://issues.apache.org/jira/browse/FLINK-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995241#comment-15995241
 ] 

ASF GitHub Bot commented on FLINK-6334:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3791#discussion_r114558126
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
 ---
    @@ -358,4 +360,45 @@ object UserDefinedFunctionUtils {
         InstantiationUtil
           .deserializeObject[UserDefinedFunction](byteData, 
Thread.currentThread.getContextClassLoader)
       }
    +
    +  /**
    +    * this method is used for create a [[LogicalTableFunctionCall]]
    +    * @param tableEnv
    +    * @param udtf a String represent a TableFunction Call e.g "split(c)"
    +    * @return
    +    */
    +  def createLogicalFunctionCall(tableEnv: TableEnvironment, udtf: String) 
= {
    --- End diff --
    
    Add return type to method


> Refactoring UDTF interface
> --------------------------
>
>                 Key: FLINK-6334
>                 URL: https://issues.apache.org/jira/browse/FLINK-6334
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> The current UDTF leverages the table.join(expression) interface, which is not 
> a proper interface in terms of semantics. We would like to refactor this to 
> let UDTF use table.join(table) interface. Very briefly,  UDTF's apply method 
> will return a Table Type, so Join(UDTF('a, 'b, ...) as 'c) shall be viewed as 
> join(Table)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to