Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3808#discussion_r114697132
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/fieldExpression.scala
---
@@ -150,3 +133,30 @@ case class WindowReference(name: String) extends
Attribute {
}
}
}
+
+abstract class TimeAttribute(val expression: Expression)
+ extends UnaryExpression
+ with NamedExpression {
+
+ override private[flink] def child: Expression = expression
+
+ override private[flink] def name: String = expression match {
+ case UnresolvedFieldReference(name) => name
+ case _ => throw new ValidationException("Unresolved field reference
expected.")
+ }
+
+ override private[flink] def toAttribute: Attribute =
+ throw new UnsupportedOperationException("Time attribute can not be
used solely.")
+}
+
+case class RowtimeAttribute(expr: Expression) extends TimeAttribute(expr) {
+
+ override private[flink] def resultType: TypeInformation[_] =
+ TimeIndicatorTypeInfo.ROWTIME_INDICATOR
+}
+
+case class ProctimeAttribute(expr: Expression) extends TimeAttribute(expr)
{
--- End diff --
I think the `expr` of `ProctimeAttribute` should not be a physical field,
Because we never use the value of physical field. e.g: we can not using
`ProctimeAttribute` as follow:
`//data (1L, 1, "Hello"),
env.fromCollection(data).toTable(tEnv, 'a, 'b, 'c.proctime)`
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
