Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3808#discussion_r114896129
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCorrelate.scala
---
@@ -44,36 +44,34 @@ trait CommonCorrelate {
*/
private[flink] def correlateMapFunction(
config: TableConfig,
- inputTypeInfo: TypeInformation[Row],
+ inputSchema: RowSchema,
udtfTypeInfo: TypeInformation[Any],
- rowType: RelDataType,
+ returnSchema: RowSchema,
joinType: SemiJoinType,
rexCall: RexCall,
condition: Option[RexNode],
pojoFieldMapping: Option[Array[Int]], // udtf return type pojo field
mapping
ruleDescription: String)
: CorrelateFlatMapRunner[Row, Row] = {
- val returnType = FlinkTypeFactory.toInternalRowTypeInfo(rowType)
-
val flatMap = generateFunction(
config,
- inputTypeInfo,
+ inputSchema.physicalTypeInfo,
udtfTypeInfo,
- returnType,
- rowType,
+ returnSchema.physicalTypeInfo,
+ returnSchema.logicalFieldNames,
joinType,
- rexCall,
+ inputSchema.mapRexNode(rexCall).asInstanceOf[RexCall],
pojoFieldMapping,
ruleDescription)
val collector = generateCollector(
config,
- inputTypeInfo,
+ inputSchema.physicalTypeInfo,
udtfTypeInfo,
- returnType,
- rowType,
- condition,
+ returnSchema.physicalTypeInfo,
+ returnSchema.logicalFieldNames,
+ condition.map(inputSchema.mapRexNode),
--- End diff --
Do we need to check that `condition` does not contain a time indicator?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
