Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3808#discussion_r114907167
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -60,26 +61,31 @@ object AggregateUtil {
* window to evaluate final aggregate value.
*
* @param generator code generator instance
- * @param namedAggregates List of calls to aggregate functions and
their output field names
- * @param inputType Input row type
+ * @param namedAggregates Physical calls to aggregate functions and
their output field names
+ * @param inputType Physical type of the row.
+ * @param inputTypeInfo Physical type information of the row.
+ * @param inputFieldTypeInfo Physical type information of the row's
fields.
* @param isRowTimeType It is a tag that indicates whether the time
type is rowTimeType
* @param isPartitioned It is a tag that indicate whether the input is
partitioned
* @param isRowsClause It is a tag that indicates whether the OVER
clause is ROWS clause
*/
private[flink] def createUnboundedOverProcessFunction(
- generator: CodeGenerator,
- namedAggregates: Seq[CalcitePair[AggregateCall, String]],
- inputType: RelDataType,
- isRowTimeType: Boolean,
- isPartitioned: Boolean,
- isRowsClause: Boolean): ProcessFunction[Row, Row] = {
+ generator: CodeGenerator,
+ namedAggregates: Seq[CalcitePair[AggregateCall, String]],
+ inputType: RelDataType,
+ inputTypeInfo: TypeInformation[Row],
+ inputFieldTypeInfo: Seq[TypeInformation[_]],
+ isRowTimeType: Boolean,
+ isPartitioned: Boolean,
+ isRowsClause: Boolean)
+ : ProcessFunction[Row, Row] = {
val needRetract = false
--- End diff --
remove or revert the next change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
