Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3673#discussion_r115787219
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/JoinITCase.scala
 ---
    @@ -372,11 +366,219 @@ class JoinITCase(
     
         val sqlQuery1 = "SELECT * FROM A CROSS JOIN (SELECT count(*) FROM A 
HAVING count(*) < 0)"
         val result = tEnv.sql(sqlQuery1).count()
    -
         Assert.assertEquals(0, result)
       }
     
       @Test
    +  def testLeftNullLeftJoin (): Unit = {
    --- End diff --
    
    We need to check the following cases:
    - LEFT JOIN, single row on the right
    - LEFT JOIN, empty input on the right
    - RIGHT JOIN, single row on the left
    - RIGHT JOIN; empty input on the left


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to