Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3673#discussion_r115783913
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/MapJoinLeftRunner.scala
---
@@ -19,19 +19,35 @@
package org.apache.flink.table.runtime
import org.apache.flink.api.common.typeinfo.TypeInformation
+import org.apache.flink.types.Row
import org.apache.flink.util.Collector
class MapJoinLeftRunner[IN1, IN2, OUT](
name: String,
code: String,
+ outerJoin: Boolean,
returnType: TypeInformation[OUT],
broadcastSetName: String)
extends MapSideJoinRunner[IN1, IN2, IN2, IN1, OUT](name, code,
returnType, broadcastSetName) {
override def flatMap(multiInput: IN1, out: Collector[OUT]): Unit = {
broadcastSet match {
case Some(singleInput) => function.join(multiInput, singleInput, out)
- case None =>
+ case None if outerJoin => function.
+ join(multiInput, null.asInstanceOf[IN2],
out)
+ case None => {
--- End diff --
The `case None =>` will only be reached for inner joins where the single
row input is empty. Since an inner join does not return anything, this case can
be empty as before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
