[
https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008062#comment-16008062
]
ASF GitHub Bot commented on FLINK-6462:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116218286
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/AggregationsTest.scala
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.table.api.scala.batch.sql
+
+import org.apache.flink.api.scala._
+import org.apache.flink.table.api.ValidationException
+import
org.apache.flink.table.api.java.utils.UserDefinedAggFunctions.OverAgg0
+import org.apache.flink.table.api.scala._
+import org.apache.flink.table.utils.TableTestBase
+import org.junit.Test
+
+class AggregationsTest extends TableTestBase {
+
+ @Test(expected = classOf[ValidationException])
--- End diff --
Please add a brief comment to each test why it is expected to fail.
> Add requiresOver interface for AggregateFunction
> -------------------------------------------------
>
> Key: FLINK-6462
> URL: https://issues.apache.org/jira/browse/FLINK-6462
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: sunjincheng
> Fix For: 1.3.0
>
>
> The window function in the standard database only supports the "over" window,
> such as `LAG`,` LEAD`, `FIRST_VALUE`,` LAST_VALUE`. These window functions do
> not apply to `Slide`,` Tumble`, `Session` window. So when the user-defined
> AGG need to be clearly defined. In calcite `SqlAggFunction` will using
> `requiresOver` to distinguish.
> In this JIRA. will deal with this feature.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
