[
https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008069#comment-16008069
]
ASF GitHub Bot commented on FLINK-6462:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116212175
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamGroupAggregateRule.scala
---
@@ -49,13 +49,19 @@ class DataStreamGroupAggregateRule
throw TableException("DISTINCT aggregates are currently not
supported.")
}
+ // check if we have over aggregates
+ val overAggs =
agg.getAggCallList.exists(_.getAggregation.requiresOver())
+ if (overAggs) {
+ throw TableException("OVER clause is necessary for requires over
window functions")
+ }
+
// check if we have grouping sets
val groupSets = agg.getGroupSets.size() != 1 ||
agg.getGroupSets.get(0) != agg.getGroupSet
if (groupSets || agg.indicator) {
throw TableException("GROUPING SETS are currently not supported.")
}
- !distinctAggs && !groupSets && !agg.indicator
--- End diff --
This check must not be removed.
> Add requiresOver interface for AggregateFunction
> -------------------------------------------------
>
> Key: FLINK-6462
> URL: https://issues.apache.org/jira/browse/FLINK-6462
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: sunjincheng
> Fix For: 1.3.0
>
>
> The window function in the standard database only supports the "over" window,
> such as `LAG`,` LEAD`, `FIRST_VALUE`,` LAST_VALUE`. These window functions do
> not apply to `Slide`,` Tumble`, `Session` window. So when the user-defined
> AGG need to be clearly defined. In calcite `SqlAggFunction` will using
> `requiresOver` to distinguish.
> In this JIRA. will deal with this feature.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
