[
https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008067#comment-16008067
]
ASF GitHub Bot commented on FLINK-6462:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116215873
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/utils/UserDefinedAggFunctions.java
---
@@ -23,13 +23,37 @@
import java.util.Iterator;
public class UserDefinedAggFunctions {
+ // Accumulator for test requiresOver
+ public static class Accumulator0 extends Tuple2<Long, Integer>{}
// Accumulator for WeightedAvg
public static class WeightedAvgAccum extends Tuple2<Long, Integer> {
public long sum = 0;
public int count = 0;
}
+ // Test for requiresOver
+ public static class OverAgg0 extends AggregateFunction<Long,
Accumulator0> {
--- End diff --
please reorder classes that the `AggregateFunction` class follows the
accumulator class
> Add requiresOver interface for AggregateFunction
> -------------------------------------------------
>
> Key: FLINK-6462
> URL: https://issues.apache.org/jira/browse/FLINK-6462
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: sunjincheng
> Fix For: 1.3.0
>
>
> The window function in the standard database only supports the "over" window,
> such as `LAG`,` LEAD`, `FIRST_VALUE`,` LAST_VALUE`. These window functions do
> not apply to `Slide`,` Tumble`, `Session` window. So when the user-defined
> AGG need to be clearly defined. In calcite `SqlAggFunction` will using
> `requiresOver` to distinguish.
> In this JIRA. will deal with this feature.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
