[
https://issues.apache.org/jira/browse/FLINK-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012231#comment-16012231
]
ASF GitHub Bot commented on FLINK-6574:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3913#discussion_r116721601
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CrudExternalCatalog.scala
---
@@ -96,13 +93,14 @@ trait CrudExternalCatalog extends ExternalCatalog {
/**
* Modifies an existing database in the catalog.
*
+ * @param dbName Name of the database.
* @param db New description of the database to update
* @param ignoreIfNotExists Flag to specify behavior if the database
does not exist:
* if set to false, throw an exception,
* if set to true, nothing happens.
* @throws DatabaseNotExistException thrown if the database does not
exist in the catalog
*/
@throws[DatabaseNotExistException]
- def alterDatabase(db: ExternalCatalogDatabase, ignoreIfNotExists:
Boolean): Unit
+ def alterDatabase(dbName: String, db: ExternalCatalog,
ignoreIfNotExists: Boolean): Unit
--- End diff --
rename to `alterSubCatalog()` or add an alias method?
> Support nested catalogs in ExternalCatalog
> ------------------------------------------
>
> Key: FLINK-6574
> URL: https://issues.apache.org/jira/browse/FLINK-6574
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Priority: Critical
> Fix For: 1.3.0
>
>
> We found out that the current external catalog requires three layers of
> references for any tables. For example, the SQL would look like the following
> when referencing external table:
> {noformat}
> SELECT * FROM catalog.db.table
> {noformat}
> It would be great to support only two layers of indirections which is closer
> to many of the deployment on Presto / Hive today.
> {noformat}
> SELECT * FROM db.table
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
