[
https://issues.apache.org/jira/browse/FLINK-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016438#comment-16016438
]
ASF GitHub Bot commented on FLINK-6574:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3913#discussion_r117349259
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -37,25 +36,10 @@ import org.apache.flink.table.plan.stats.TableStats
* @param lastAccessTime Timestamp of last access of the table
*/
case class ExternalCatalogTable(
- identifier: TableIdentifier,
--- End diff --
The properties field is exactly meant to hold configuration parameters such
as hostnames, ports, paths, or client configs.
I think @haohui is right. Not all external tables require a name to access
the data (the name under which the table is registered in the catalog and
identified by Calcite is the key in the map). A CSV file table needs a path, a
Kafka-based table a Kafka config + topic name, etc. A database table which
needs a table name could store the table name (and also the database name and
schema name) in the properties map.
Would that work for you @KurtYoung?
> Support nested catalogs in ExternalCatalog
> ------------------------------------------
>
> Key: FLINK-6574
> URL: https://issues.apache.org/jira/browse/FLINK-6574
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Priority: Critical
> Fix For: 1.3.0
>
>
> We found out that the current external catalog requires three layers of
> references for any tables. For example, the SQL would look like the following
> when referencing external table:
> {noformat}
> SELECT * FROM catalog.db.table
> {noformat}
> It would be great to support only two layers of indirections which is closer
> to many of the deployment on Presto / Hive today.
> {noformat}
> SELECT * FROM db.table
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
