[ 
https://issues.apache.org/jira/browse/FLINK-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016247#comment-16016247
 ] 

ASF GitHub Bot commented on FLINK-6574:
---------------------------------------

Github user haohui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3913#discussion_r117325036
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
 ---
    @@ -37,25 +36,10 @@ import org.apache.flink.table.plan.stats.TableStats
       * @param lastAccessTime       Timestamp of last access of the table
       */
     case class ExternalCatalogTable(
    -    identifier: TableIdentifier,
    --- End diff --
    
    I agree that it requires keeping more than the name of the table. The more 
general problem is that you will need to keep additional information for other 
data sources (e.g., the clusters for Kafka topics)
    
    I think it might make more sense to put the information at the properties 
field in `ExternalCatalogTable`. Thoughts?


> Support nested catalogs in ExternalCatalog
> ------------------------------------------
>
>                 Key: FLINK-6574
>                 URL: https://issues.apache.org/jira/browse/FLINK-6574
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>            Priority: Critical
>             Fix For: 1.3.0
>
>
> We found out that the current external catalog requires three layers of 
> references for any tables. For example, the SQL would look like the following 
> when referencing external table:
> {noformat}
> SELECT * FROM catalog.db.table
> {noformat}
> It would be great to support only two layers of indirections which is closer 
> to many of the deployment on Presto / Hive today.
> {noformat}
> SELECT * FROM db.table
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to